Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): update patch for typescript@5.4.0-beta #6110

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jan 29, 2024

What's the problem this PR addresses?

The PnP compatibility patch for TypeScript doesn't apply to typescript@5.4.0-beta.

Ref microsoft/TypeScript#35206

How did you fix it?

Rebased it.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 16c1d99 into master Jan 30, 2024
26 checks passed
@arcanis arcanis deleted the merceyz/fix/typescript-54-beta branch January 30, 2024 14:21
merceyz added a commit that referenced this pull request Jan 30, 2024
**What's the problem this PR addresses?**

The PnP compatibility patch for TypeScript doesn't apply to
`typescript@5.4.0-beta`.

Ref microsoft/TypeScript#35206

**How did you fix it?**

Rebased it.

**Checklist**
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).
- [x] I have set the packages that need to be released for my changes to
be effective.
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

(cherry picked from commit 16c1d99)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants